Conversation
renovate
Bot
force-pushed
the
renovate/errorprone-packages
branch
from
ff7e4a5 to
619391e
Compare
github-actions
Bot
requested review from
JonasKunz,
SylvainJuge,
cyrille-leclerc,
jackshirazi and
kenfinnigan
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Error Prone toolchain to v2.49.0 and adjusts a couple of code locations to align with updated Error Prone APIs/checks.
Changes:
- Bump
com.google.errorpronedependencies from2.48.0to2.49.0in the dependency management platform. - Fix null-check logic in
GoogleJibBuildHandlerfor Jib plugin configuration nodes. - Update
SamplingProfilerJavadoc reference to match the updatedCallTree#spanify(...)signature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dependencyManagement/build.gradle.kts |
Updates Error Prone artifacts to 2.49.0. |
maven-extension/.../GoogleJibBuildHandler.java |
Corrects null checks for to and to/image nodes. |
inferred-spans/.../SamplingProfiler.java |
Updates Javadoc method signature reference; adds BiConsumer import (currently problematic). |
| import java.util.function.BiConsumer; | ||
| import java.util.function.Supplier; |
There was a problem hiding this comment.
BiConsumer is imported but only referenced in a Javadoc {@linkplain ...} method signature. Since the build enables -Xlint:all and -Werror, this unused import will fail compilation. Remove the import and either fully-qualify the type in the Javadoc link (e.g., java.util.function.BiConsumer) or change the link to avoid embedding the full signature.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This PR contains the following updates:
2.48.0→2.49.02.48.0→2.49.02.48.0→2.49.0Release Notes
google/error-prone (com.google.errorprone:error_prone_test_helpers)
v2.49.0: Error Prone 2.49.0This release includes several changes to
MatcherAPIs, and removed some deprecated or problematic APIs:MethodMatchers.withSignatureAPI, which relies on fragiletoStringbehaviour. Alternatives for matching on method signatures with varargs and type parameters were added ina98a1c5.variableType(Matcher)API.Matchers.variableType(Matcher)usesVariableTree#getTypeto match variable types, which own't work for lambda parameters with inferred types after JDK-8268850. The recommended replacement isvariableType(TypePredicate).enclosingPackagereturn an optional. Module elements are not enclosed by a package, checks usingenclosingPackageshouldn't assume an enclosing package exists when processing arbitrary elements.FieldMatchersAPI, similar toMethodMatchers(1dd9c3a).New checks:
AssertThrowsBlockToExpression: Discourage unnecessary block lambdas inassertThrows.AssertThrowsMinimizer: Suggest minimizing the amount of logic inassertThrows.MemorySegmentReferenceEquality: Discourage using reference equality forMemorySegments.PreferThrowsTag: Recommends using@throwsinstead of the legacy@exceptionjavadoc tag.RecordAccessorInCompactConstructor: detect record accessors inside the compact canonical ctors, which read uninitialized fields.Closed issues: #2283, #3503, #5210, #5289, #5548, #5548, #5554, #5609, #5614, #5656
Full changelog: google/error-prone@v2.48.0...v2.49.0
Configuration
📅 Schedule: (UTC)
* 0-7 * * 2)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.